History | Log In     View a printable version of the current page.  
Issue Details (XML)

Key: FB-9525
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: A+ A+
Assignee: Steve Silvers
Reporter: Christophe Jolif
Votes: 6
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Flex Builder

Subclipse SVN plugin requires the feature org.eclipse.jdt

Created: 09/18/07 05:00 AM   Updated: 10/22/07 01:05 PM
Component/s: Standalone
Security Level: Public (All JIRA Users )

Issue Links:
Duplicate
 
This issue is duplicated by:
FB-10240 cannot install JSEclipse using update... None Closed

Severity: Non Functioning
Reproducibility: Every Time
Discoverability: Medium
Found in Version: Moxie M3 (Beta 2) - 182489
Milestone: Moxie M3 (zero)
Affected OS(s): Windows
Steps to Reproduce:
Steps to reproduce:
1. Install SVN plugin at : http://subclipse.tigris.org/update_1.2.x/
2.
3.
 
 Actual Results:
 This fails:
Eclipse Modeling Framework (EMF) - org.eclipse.emf.codegen.ui (2.3.0.v200706262000) requires plug-in "org.eclipse.jdt.core".
 
 Expected Results:
 It should work. Actually it was working with previous FlexBuilder drops.
 
 Workaround (if any):
 
 
 
Language Found: English
Bugbase Id: none
Triaged: Yes
Regression: Yes
QA Owner: Steve Silvers
Resolved by: Steve Silvers
Fixed Version: Moxie M3 (Beta 2) - 183332
Confirmed Version: Moxie M3 (zero) - 185290
Participants: Brent Arndorfer, cagruss, Christophe Jolif, Heidi Williams, Kristen, Larry McLister, Mark Phippard, Mike Schiff and Steve Silvers
Eclipse Configuration: FB Standalone


 All   Comments      Sort Order:
Steve Silvers - [09/18/07 02:59 PM ]
reproed in 182700 vista standalone

cagruss - [09/18/07 03:43 PM ]
This is related to upgrading to the latest version of EMF that's compatible with eclipse 3.3. This latest version requires including the feature named org.eclipse.emf.codegen.ui, that has a dependency on org.eclipse.jdt.core. We don't include org.eclipse.jdt.core with our standalone distribution, hence the error. Installing FB3 Plugin into a full copy of eclipse doesn't have this problem, because org.eclipse.jdt.core is included already, of course.

The most straightforward solution would be to start including org.eclipse.jdt.core as part of our standalone distribution. Would that be an acceptable change? Short of that, we would need to hack the org.eclipse.emf.* features apart, and try distributing them as isolated plugins instead of as part of a unified feature set, and that would be a bit of a nightmare.

Heidi Williams - [09/19/07 03:44 PM ]
QRB opened to Chris. Didn't you already fix this? If so, please mark fixed.

cagruss - [09/19/07 04:04 PM - edited ]
Tried fixing this by including the plugin org.eclipse.jdt.core in our standalone distros for both Win and Mac. This didn't resolve the problem though - it appears that there's a bug in the depdency tree for og.eclipse.emf, that may require installing the full org.eclipse.jdt feature, and not just the one plugin org.eclipse.jdt.core.

Mike Schiff - [09/22/07 05:23 PM ]
org.eclipse.jdt.core shows up under plugin details, but I nevertheless get errors trying to install subclipse (windows XP). (Build 183263)

The current configuration contains errors and this operation can have unpredictable results.
  Eclipse Modeling Framework (EMF) - org.eclipse.emf.codegen (2.3.0.v200706262000) requires plug-in "org.eclipse.jdt.core".
  Eclipse Modeling Framework (EMF) - org.eclipse.emf.converter (2.3.0.v200706262000) requires plug-in "org.eclipse.jdt.core".
  Eclipse Modeling Framework (EMF) - org.eclipse.emf.codegen.ecore.ui (2.3.0.v200706262000) requires plug-in "org.eclipse.jdt.core".
  Eclipse Modeling Framework (EMF) - org.eclipse.emf.codegen.ecore (2.3.0.v200706262000) requires plug-in "org.eclipse.jdt.core".
  Eclipse Modeling Framework (EMF) - org.eclipse.emf.codegen.ui (2.3.0.v200706262000) requires plug-in "org.eclipse.jdt.core".

Christophe Jolif - [09/24/07 04:21 AM ]
Build 183158 still shows the exact same pb. (missing emf).

Steve Silvers - [09/24/07 01:15 PM ]
When I last looked at this, it worked. Did branching break this again?

Heidi Williams - [09/25/07 01:44 PM - edited ]
This should be fixed now, however on the Mac you have to check the Europa discovery site checkbox to make sure all the SVN required pieces are installed correctly.

[Editors note: it should make no difference whether you're on Win or Mac. There's a bug in the dependency tree for org.eclipse.emf that's causing this same problem on both platforms.]

Christophe Jolif - [09/26/07 03:21 AM ]
I still have the problem on build 183522

Larry McLister - [09/26/07 01:41 PM - edited ]
sending to IRB.

Work around is:
- Help > Software updates > Find and install. Select search for new features to install.
- Check the Europa discovery site and the SubEclipse update site. (add the SubEclipse site via 'New Remote Site' if it isn't present http://subclipse.tigris.org/update_1.2.x/ )
- Click finish.
- Check SubEclipse and in the Europa discovery site check "Eclipse Java Development Tools" under "Java Development" .
- Cick next and complete the wizard.

Kristen - [10/02/07 12:52 PM ]
It does not work to only select Java Development. These other ones must be selected as well:

- Database Development
- Enabling Features
- Models and Model Development
- Web and JEE Development

Kristen - [10/02/07 12:58 PM ]
Please ignore the last comment. You might want to clarify with the steps that "Eclipse Java Development Tools" under "Java Development" needs to be checked and not the entire "Java Development" directory.

Larry McLister - [10/04/07 12:51 AM ]
Thanks for the correction. I've updated the work around.

Heidi Williams - [10/04/07 11:31 PM ]
QRB opened to Chris. Let's talk about what the options are here.

cagruss - [10/08/07 11:38 AM ]
We tried fixing this by including the plugin org.eclipse.jdt.core in our standalone distros for both Win and Mac. This didn't resolve the problem though - it appears that there's a bug in the depdency tree for og.eclipse.emf, that may require installing the full org.eclipse.jdt feature, and not just the one plugin org.eclipse.jdt.core.

In the past, we've avoided installing the full org.eclipse.jdt feature with our Standalone distros because of UI issues, so we'll need to revisit this trade-off.

cagruss - [10/08/07 03:09 PM - edited ]
I ran a careful test, and confirmed that the only way to avoid this error is to include the full feature named org.eclipse.jdt_3.3.x, including its plugin named org.eclipse.jdt.ui_3.3x. The error message given about EMF not finding the required plugin named org.eclipse.jdt.core is an eclipse bug that was confusing us - I've determined that it really needs the intact JDT feature to avoid the error.

Suggesting that we add in the full JDT feature for our FB3 Standalone distribution, and assess the actual impact on the Standalone UI. I think there's a good chance that it will not have the big impact feared, and that the FB UI will still be in a good state.

The resulting UI would be the same one you'd get if you start with FB3 Standalone, and then use the Europa Discovery site to add on JDT. Would someone be able to try this out soon, to evaluate the UI impact?

Heidi Williams - [10/09/07 02:18 PM ]
NJ can you investigate what would happen if we installed the whole JDT into standalone?

Mark Phippard - [10/10/07 02:56 PM - edited ]
I am the Subclipse maintainer and just want to clarify something. Subclipse does not have any dependency on JDT. The message is telling you that a plugin you are already installing with FB3 requires JDT:

 org.eclipse.emf.codegen.ui

So you are installing an invalid Eclipse installation. You probably want to stop including that part of EMF with FB3 and that will solve the problem.

[Editors note: we understand that Eclipse is reporting an error, but the problem is that the error itself is incorrect. It says that it cannot find the plugin org.eclipse.jdt.core, when in fact that plugin is definitely present. Almost certainly this was a bug in eclipse 3.3.0, and we think it was fixed in eclipse 3.3.1. We'll find out for certain when we upgrade the standalone distros to 3.3.1 this month.]

The Eclipse install mechanism reports any problems in the current configuration when you try to install another plugin. So you would get this message when trying to install ANY other plugin.

The Select Required option does not work, because Subclipse does not require JDT. That option should probably be enhanced in Eclipse to select plugins required but not found in the current configuration too.

I thought that as of Eclipse 3.2 you could still install other plugins when you had these problems and they were just warnings. Was the Finish button not enabled?

Brent Arndorfer - [10/12/07 09:56 AM ]
No, Mark, the finish button is NOT enabled in this case.

Heidi Williams - [10/15/07 04:19 PM ]
After reviewing this with NJ, it's clear that our base install is not complete. It is not okay for us to install the JDT UI so we should see if we can pare down what we install further so that it is not invalid and does support our data wizard feature.

Heidi Williams - [10/15/07 05:42 PM ]
Chris, Larry's steps do work (install Europa and Subclipse together) so it's true that you can install the JDT in order to install Subclipse. There were some new perspectives and menu items so it does alter our UI. Can we investigate if we can further reduce the set of plugins we install to support data wizard so that we don't pull in the things that require the JDT?

cagruss - [10/15/07 08:17 PM - edited ]
Yes, I'll take another pass at this as we upgrade to eclipse 3.3.1 this month for our basic Standalone feature set.

I'm am reasonably certain that we can't remove any of the current EMF features, because the DTP features depend on them explicitly, and in turn our dbwizard plugin depends on DTP. The feature-level dependencies are complicated enough to manage at the high level, but breaking things down into plugin-level dependencies could result in a maintenance nightmare at the low level.

Yet, I may be able to work around the problem by including more of the JDT plugins on their own, without including the full feature set. The error given by the update manger API in eclipse 3.3.0 is clearly incorrect, as we've already confirmed in the thread above that the jdt.core plugin is present.

I've noticed that the plugin org.eclipse.emf.codegen.ui also requires the plugin named org.eclipse.jdt.launching, so I think perhaps that was the real source of the error. Adding in the jdt.launching plugin doesn't fix the problem though, because jdt.launching depends on the plugin jdt.debug, and jdt.debug in turn depends on a lot of other jdt plugins.

In the end, we may need to either take the whole JDT feature, or perhaps everything except the jdt UI plugins, if we can do that without violating internal JDT dependencies. I'll experiment further with eclipse 3.3.1, and will report back.

cagruss - [10/19/07 07:38 PM - edited ]
Sad to say that upgrading the FB standalone distros to eclipse 3.3.1 hasn't improved this situation. The eclipse update manager still seems intent on finding the whole JDT feature, even though all of the plugins required to satisfy the EMF dependencies are present.

I'll see if there's a new set of updates for the EMF feature itself, in case this will make a difference.

cagruss - [10/20/07 09:33 AM - edited ]
I found a solution for this that's so easy it feels a bit like cheating. I've bypassed this problem in our standalone distributions by excluding the feature folders for all of the DTP-related features: EMF, GEF, & DTP.

This way all of the required plugins are still present, satisfying all of the runtime dependencies, but the Configuration Manager won't worry about them, as it only appears to deal with them at the feature level. The Configuration Manager had been complaining that the plugin org.eclipse.jdt.core wasn't present (though it really was), apparently because it depends on the parent feature org.eclipse.jdt being present, and doesn't really know what plugins are available otherwise.

This first build that includes this change in the staged DTP features is 185273.

Steve Silvers - [10/22/07 12:53 PM ]
Instead of getting an error about jdt.core, i get an error that says
 ----- Current configuration problems -----

This feels not fixed to me

Steve Silvers - [10/22/07 01:05 PM ]
sorry about that. looks like the problem was with my install. i uninstalled and reinstalled and it now works ok