 |
History
| Log In
|
|
|
|
Reproduced in an image of Suse linux 9.3.
To be able to run the checkintest, I had to: - unzip /flex/sdk/trunk/in/player/lnx/flashplayer.tar.gz - add the following in build.xml <condition property="flash.player" value="${basedir}/in/player/lnx/flashplayer"> <os family="unix"/> </condition> setup.sh was modified after the patch was submitted.
Checking for JAVA_HOME and ANT_HOME setting was removed. According to Jono, this was not how it was supposed to work for mac and windows. The patch for the linux part remains as-is, aside from the checking of JAVA_HOME and ANT_HOME. It is noted in setup.sh that you'll have to edit the paths if java and ANT are not installed in the location indicated. So not having the checking of JAVA_HOME and ANT_HOME may be fine. However, shouldn't the default paths in linux setup up point to specific java and ANT builds (like mac and windows) so that it's more clear that ant1.7 and jdk1.5 are the required versions when building the project? i.e ANT_HOME=/usr/share/apache-ant-1.7.0 "So not having the checking of JAVA_HOME and ANT_HOME may be fine. "
Depends on the intent of setup.sh - should it just setup the build environment (to some defaults that may or may not be correct), or attempt to find problems (and fix them if possible). The latter was my intent in checking /etc/alternatives if JAVA_HOME wasn't set, for instance. The deps on specific Ant and JDK versions was announced after my initial patch. Simple checks on, for instance, `$JAVA_HOME/bin/java -version` or similar should suffice. If it's meant to be a cross-platform environment checker/configurer then I don't mind (re)doing the Linux bits. If setup.sh is meant to just be an example of what environment vars are required, why not just remove it and update the build docs ? The whole point of the script is to instantly, and forcibly, set up the environment correctly for your OS. Many systems already have JAVA_HOME set up; that's well and good but we're interested in it being the correct version, so if it's already set, and you don't want to change it, don't use the script.
The script matches the documentation on the open source page; and for a Mac, it matches the out-of-box locations of Java. If you'd like to provide instructions to add for Linux, and any other Linux changes, that'd be great! We need this script to work for people who have never built before, and it does work for vets who've been working on the code for a long time -- you may have to edit a path here or there, no big deal. The script does find problems of missing paths -- if ant is not found, it will warn you -- that warning should cause you to fix where ant is on the system or in the script. Further, the deps on specific Ant and JDK existed before your patch, it was in the docs, and the original paths specified ant 1.6.2 and java 1.4.2. does that clear things up? Perfectly Jono, cheers.
It appears the checks for an previously unpacked player on Linux got lost in the shuffle. Patch attached. Actually, that's in there. Is it not working? See line 31 of the latest build.xml:
<condition property="flash.player" value="${basedir}/in/player/lnx/flashplayer"> <os family="unix"/> </condition> Does that not work -- is there another os family we should be using? One of our devs uses Linux for development, I think it works for him... Jono - I meant in the setup.sh, not the ant build.xml - see #
confirmed fix by calling the following:
rm in/player/lnx/flashplayer source setup.sh (unpacks flashplayer since it doesn't exist in the folder yet) source setup.sh (did not unpack player) touch in/player/lnx/flashplayer.tar.gz source setup.sh (unpacks player) | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Bug
Closed
None
Flex trunk does not compile out of the box on Linux
It would be really helpful if you could go through these steps:
http://opensource.adobe.com/wiki/display/flexsdk/Submitting+a+Patch
to submit patches for build.xml and setup.sh. (We can test the procedure for open source contributions too.)
Thanks!
- Rob