« Hide

The method setselectedItem of ComboBox doesn't take into account if the object you are trying to select implements IUID or not.


In the method setSelectedIndex of ComboboxBase there is a comparison with ==. The method should test if the objects you are passing implements IUID or not. If they implement both of them should be compared using the uid.

=====================================
private function setSelectedItem(data:Object, clearFirst:Boolean = true):void
    {
        //2 code paths: one for before collection, one after
        if (!collection || collection.length == 0)
        {
            _selectedItem = value;
            selectedItemChanged = true;
            invalidateDisplayList();
            return;
        }

        var found:Boolean = false;
        var listCursor:IViewCursor = collection.createCursor();
        var i:int = 0;
        do
        {
            if (data == listCursor.current) //THIS SHOULD BE CHANGED
            {
                _selectedIndex = i;
                _selectedItem = data;
                selectedUID = itemToUID(data);
                selectionChanged = true;
                found = true;
                break;
            }
            i++;
        }
        while (listCursor.moveNext());

        if (!found)
        {
            selectedIndex = -1;
            _selectedItem = null;
            selectedUID = null;
        }

        invalidateDisplayList();
    }
=====================================
 
Solution:
=======
Change line

if (data == listCursor.current)

with a method invocation and method like the following:

=====================================
if (equals(data,listCursor.current))

public function equals(a:Object,b:Object):Boolean{
if (a==null || b==null)
return false;

if (a is IUID)
if (b is IUID)
return a.uid == b.uid;
else
return false;
else
return a == b;
}
=====================================


I suppose that this kind of comparisons are spread across the code so please take that into account.

For developers I'm sure it's extremely important Flex and Actionscript to support equality.

Please try to solve this

Show »

The method setselectedItem of ComboBox doesn't take into account if the object you are trying to select implements IUID or not. In the method setSelectedIndex of ComboboxBase there is a comparison with ==. The method should test if the objects you are passing implements IUID or not. If they implement both of them should be compared using the uid. ===================================== private function setSelectedItem(data:Object, clearFirst:Boolean = true):void     {         //2 code paths: one for before collection, one after         if (!collection || collection.length == 0)         {             _selectedItem = value;             selectedItemChanged = true;             invalidateDisplayList();             return;         }         var found:Boolean = false;         var listCursor:IViewCursor = collection.createCursor();         var i:int = 0;         do         {             if (data == listCursor.current) //THIS SHOULD BE CHANGED             {                 _selectedIndex = i;                 _selectedItem = data;                 selectedUID = itemToUID(data);                 selectionChanged = true;                 found = true;                 break;             }             i++;         }         while (listCursor.moveNext());         if (!found)         {             selectedIndex = -1;             _selectedItem = null;             selectedUID = null;         }         invalidateDisplayList();     } =====================================   Solution: ======= Change line if (data == listCursor.current) with a method invocation and method like the following: ===================================== if (equals(data,listCursor.current)) public function equals(a:Object,b:Object):Boolean{ if (a==null || b==null) return false; if (a is IUID) if (b is IUID) return a.uid == b.uid; else return false; else return a == b; } ===================================== I suppose that this kind of comparisons are spread across the code so please take that into account. For developers I'm sure it's extremely important Flex and Actionscript to support equality. Please try to solve this